fix(fastapi): resolve session lifecycle timing with generator dependencies #648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #647
This PR resolves the session lifecycle timing conflict between Starlette middleware and FastAPI's generator-based dependency cleanup (
provide_service()). The issue was causing asyncpg connections to not be properly returned to the pool, resulting in:InvalidRequestError: An invalid request was made.SAWarning: The garbage collector is trying to clean up non-checked-in connection...Root Cause
The middleware was closing sessions before FastAPI's generator dependency cleanup could run:
Solution
provide_service()finallyblock with access to the stored response statusChanges
advanced_alchemy/extensions/fastapi/providers.py_should_commit_for_status()helper, updateprovide_service()to handle lifecycleadvanced_alchemy/extensions/starlette/config.pytests/unit/test_extensions/test_fastapi/test_session_lifecycle.pyTest Plan
_should_commit_for_status()helper function