Skip to content

feat: Make HTMXRequest generic#14

Merged
provinzkraut merged 1 commit into
litestar-org:mainfrom
marcuslimdw:make-htmx-request-generic
Jul 31, 2025
Merged

feat: Make HTMXRequest generic#14
provinzkraut merged 1 commit into
litestar-org:mainfrom
marcuslimdw:make-htmx-request-generic

Conversation

@marcuslimdw

@marcuslimdw marcuslimdw commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

Description

Add type parameters to HTMXRequest that mirror those of litestar.Request, allowing type-safe (ish) access to the user, auth, and state attributes of HTMXRequest.

Closes

Fixes #13.

Summary by Sourcery

Enhancements:

  • Add Generic[UserT, AuthT, StateT] parameters to HTMXRequest to allow type-safe access to user, auth, and state attributes

@sourcery-ai

sourcery-ai Bot commented Jul 31, 2025

Copy link
Copy Markdown

Reviewer's Guide

Enhance HTMXRequest by introducing generic type parameters to align with litestar.Request, enabling type-safe access to user, auth, and state attributes.

Class diagram for generic HTMXRequest

classDiagram
    class Request~UserT, AuthT, StateT~ {
        +user: UserT
        +auth: AuthT
        +state: StateT
    }
    class HTMXRequest~UserT, AuthT, StateT~ {
        +htmx
    }
    HTMXRequest~UserT, AuthT, StateT~ --|> Request~UserT, AuthT, StateT~
Loading

File-Level Changes

Change Details Files
Parameterize HTMXRequest with generics to mirror litestar.Request
  • Add Generic[UserT, AuthT, StateT] to HTMXRequest class definition
  • Extend HTMXRequest inheritance to Request[UserT, AuthT, StateT]
litestar_htmx/request.py

Assessment against linked issues

Issue Objective Addressed Explanation
#13 Make HTMXRequest generic in UserT, AuthT, and StateT, mirroring litestar.Request.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marcuslimdw - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@marcuslimdw marcuslimdw changed the title (feat) Make HTMXRequest generic feat: Make HTMXRequest generic Jul 31, 2025
@provinzkraut provinzkraut merged commit 9ce3561 into litestar-org:main Jul 31, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: HTMXRequest is not generic, unlike Request

2 participants