Skip to content

feat: update to v3 themeing#15

Open
JacobCoffee wants to merge 19 commits into
mainfrom
v3
Open

feat: update to v3 themeing#15
JacobCoffee wants to merge 19 commits into
mainfrom
v3

Conversation

@JacobCoffee

@JacobCoffee JacobCoffee commented Apr 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Previews

Details

Core

image

API Docs

image

Landing
image

Usage
image

@JacobCoffee JacobCoffee mentioned this pull request Apr 6, 2024
Closed
5 tasks
@JacobCoffee

This comment was marked as resolved.

Sign in to view
@JacobCoffee

JacobCoffee commented Apr 6, 2024

Copy link
Copy Markdown
Member Author

Version tab code blocks from auto_pytabs is not rendering properly (e.g., no rounded corners, bg color different than .. code-block:: directives

image

@JacobCoffee

JacobCoffee commented Apr 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

In general also code-block and .. literalinclude:: highlighting is weird compared to v2 docs

edit: seems they are using

--syntax-dark-text: 
--syntax-light-text:

and that is painful :\

@JacobCoffee

JacobCoffee commented Apr 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Not sure if I'm dumb but enabling [Source] button for code isnt rendering like it has in https://docs.byte-bot.app/latest/byte/api/bot.html or https://docs.advanced-alchemy.jolt.rs/latest/reference/base.html

@JacobCoffee JacobCoffee mentioned this pull request Apr 6, 2024
Merged
@JacobCoffee

JacobCoffee commented Apr 7, 2024

Copy link
Copy Markdown
Member Author

Hi @lepture sorry for the rogue ping, but related to your color PR from the other the Advanced Alchemy repo I thought you might have some good insight into possible improvements here.

No pressure - we just appreciate your lib a whole lot :)

lepture
lepture reviewed Apr 10, 2024
View reviewed changes
Comment thread litestar_sphinx_theme/__init__.py
# waiting for shibuya#32
# context["reddit_link"] = theme_options.get(
# "reddit_link",
context["reddit_url"] = theme_options.get(

@lepture lepture Apr 10, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shibuya theme supports Reddit natively now.

@JacobCoffee JacobCoffee Apr 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! thats why I uncommented and added.
This is so that we dont need to define it in each of our projects conf.py 😄. Actually set in theme.conf this seems sortve redundant but i was keeping with the prior work in letting people set it differently if for some reason

@JacobCoffee

JacobCoffee commented Apr 10, 2024

Copy link
Copy Markdown
Member Author

Version words do not show but caret dropdown does. Probably a me issue to fix before v3 release
image

@JacobCoffee

JacobCoffee commented Apr 10, 2024

Copy link
Copy Markdown
Member Author

I'm not sure what the cause/purpose of this hamburger menu is.
image

@lepture

lepture commented Apr 10, 2024

Copy link
Copy Markdown

@JacobCoffee the hamburger menu should only be shown in mobile viewport.

provinzkraut
provinzkraut approved these changes Apr 10, 2024
View reviewed changes

@provinzkraut provinzkraut left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @JacobCoffee

JacobCoffee and others added 6 commits April 26, 2024 22:31
@JacobCoffee
docs: new discord link
30aafc8
@JacobCoffee
style: update logo and css
7e2b31f
@JacobCoffee
style: fix theme logo
4799f93
@cofin
Merge branch 'main' into v3
e5f1df5
@JacobCoffee @cofin
V3 uv (#17)
4ea4888 
* feat: move to `uv`

* chore: bump deps

* chore: updated config

* fix:

* feat: build update

---------

Co-authored-by: Cody Fincher <cody@litestar.dev>
@JacobCoffee
docs: do not use custom syntax pygment stuff
b5d0276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@provinzkraut provinzkraut provinzkraut approved these changes
+1 more reviewer
@lepture lepture lepture left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JacobCoffee @lepture @provinzkraut @cofin