Skip to content

docs: Update Offset Pagination With SQLAlchemy example #4144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v3.0
Choose a base branch
from

Conversation

ames0k0
Copy link

@ames0k0 ames0k0 commented Apr 24, 2025

Add missing sync_to_thread=False argument
Also fixed the slice method arguments

Description

slice context

# sqlalchemy/sql/util.py
# start=1, stop=3
limit_clause = _offset_or_limit_clause(stop - start)
# sqlite
select * from person limit -2 offset 3;
-- ...

# postgres
select * from person limit -2 offset 3;
-- LIMIT must not be negative

Closes

#4141

Add missing `sync_to_thread=False` argument
Also fixed the `slice` method arguments
@ames0k0 ames0k0 requested review from a team as code owners April 24, 2025 22:40
@github-actions github-actions bot added area/docs This PR involves changes to the documentation size: small type/docs pr/external Triage Required 🏥 This requires triage labels Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs This PR involves changes to the documentation pr/external size: small Triage Required 🏥 This requires triage type/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant