fix(multipart): return HTTP 413 for size limit violations#4484
Closed
nclimaz wants to merge 6 commits intolitestar-org:mainfrom
Closed
fix(multipart): return HTTP 413 for size limit violations#4484nclimaz wants to merge 6 commits intolitestar-org:mainfrom
nclimaz wants to merge 6 commits intolitestar-org:mainfrom
Conversation
github-actions
bot
added
area/multipart
area/private-api
Changed ClientException to RequestEntityTooLarge when multipart request exceeds size limits, returning HTTP 413 status code instead of HTTP 400 per RFC 7231. Closes litestar-org#4439
nclimaz
force-pushed
the
fix/multipart-413-error
branch
from
02e661d to
756d392
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed ClientException to RequestEntityTooLarge when multipart request exceeds size limits, returning HTTP 413 status code instead of HTTP 400 per RFC 7231.
Closes #4439
Description
Changes the exception raised when multipart requests exceed size limits from
ClientException(HTTP 400) toRequestEntityTooLarge(HTTP 413).Changes
litestar/_multipart.pyline 138 to useRequestEntityTooLargeRequestEntityTooLargeWhy
HTTP 413 is the correct status code for "Request Entity Too Large" per RFC 7231, not 400 Bad Request.
Testing
test_multipart_413.pyCloses 4439