-
-
Notifications
You must be signed in to change notification settings - Fork 530
Fix/multipart 413 pr #4485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Fix/multipart 413 pr #4485
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
756d392
fix(multipart): return HTTP 413 for size limit violations
nclimaz d0f9187
fix(tests): correct indentation in test_multipart_413.py
nclimaz 86b2d21
fix(tests): correct indentation in test_multipart_413.py
nclimaz b82fe0b
fix(multipart): fix lint issues, remove tabs, add missing import, and…
nclimaz f054af4
fix(multipart): fix lint issues, remove tabs, add missing import, and…
nclimaz c2455f9
fix(multipart): fix lint issues, remove tabs, add missing import, and…
nclimaz da60a67
Fix: Return HTTP 413 for multipart form size limit exceeded
nclimaz d810de3
fix: address code review feedback
nclimaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this being imported here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@provinzkraut I've addressed the feedback with one clarification:
I did not remove the except StopAsyncIteration: block. Removing it caused a runtime failure (NameError: name 'async_next' is not defined) and resulted in a 500 instead of the expected 413. Keeping the explicit exception handling ensures the correct 413 response is returned.