Skip to content

refactor: do not do 3 lookups of q in priority #4664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 1 commit into from
Apr 3, 2026
+4 −3
Merged

refactor: do not do 3 lookups of q in priority #4664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions litestar/datastructures/headers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,15 +398,16 @@ def priority(self) -> tuple[int, int]:
# Use fixed point values with two decimals to avoid problems
# when comparing float values
quality = 100
if "q" in self.params:
qparam = self.params.get("q")
if qparam is not None:
with suppress(ValueError):
quality = int(100 * float(self.params["q"]))
quality = int(100 * float(qparam))

if self.maintype == "*":
specificity = 0
elif self.subtype == "*":
specificity = 1
elif not self.params or ("q" in self.params and len(self.params) == 1):
elif not self.params or (qparam is not None and len(self.params) == 1):
# no params or 'q' is the only one which we ignore
specificity = 2
else:
Expand Down
Loading