fix: add an explicit test that q can be non-float#4667
Merged
provinzkraut merged 2 commits intomainfrom Apr 4, 2026
Merged
Conversation
This `suppress(ValueError)` was never tested: https://github.com/litestar-org/litestar/blob/55b69239fda945518f0dc69f7c511efb2d836c7f/litestar/datastructures/headers.py#L403-L404
github-actions
bot
added
size: small
type/bug
pr/external
Triage Required 🏥
provinzkraut
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
suppress(ValueError)was never tested:litestar/litestar/datastructures/headers.py
Lines 403 to 404 in 55b6923
I also removed a duplicate test case.
📚 Documentation preview 📚: https://litestar-org.github.io/litestar-docs-preview/4667