fix: ensure BaseRouteHandler.on_registration is only called once per handler#4738
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4738 +/- ##
=======================================
Coverage 67.37% 67.38%
=======================================
Files 292 292
Lines 14996 14999 +3
Branches 1684 1685 +1
=======================================
+ Hits 10104 10107 +3
Misses 4756 4756
Partials 136 136 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
provinzkraut
force-pushed
the
fix-call-on-registration
branch
from
April 26, 2026 17:34
32cc9a9 to
0dbccc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue that would lead to
BaseRouteHandler.on_registrationbeing called more than once if a handler instance was registered for multiple paths (i.e.@get(["/a", "/b"])). This fix only targets v3 even though the behaviour also exists in v2. In v2 this is much harder to fix and uncertain which side effects it might introduce in downstream apps due to the mutable nature of the handlers pre #3900.📚 Documentation preview 📚: https://litestar-org.github.io/litestar-docs-preview/4738