Skip to content

Comments

fix: tests failing on ARM MacOS#82

Merged
cofin merged 2 commits intolitestar-org:mainfrom
peterHoburg:peterhoburg/#81-test-fail-on-mac-os-arm
May 24, 2025
Merged

fix: tests failing on ARM MacOS#82
cofin merged 2 commits intolitestar-org:mainfrom
peterHoburg:peterhoburg/#81-test-fail-on-mac-os-arm

Conversation

@peterHoburg
Copy link
Contributor

I tried getting this setup to contribute on ARM MacOS and ran into some issues. Here is my first pass at "fixing" (skipping some tests...) a lot of the issues.

Closes #81

…e no docker images. Some tests need to be skipped on ARM because there is a bug in pymssql.

Changed the way tests are run to force subprocess. This might be a ARM only issue as well?
Added psycopy-binary for dev. This fixes ANOTHER ARM/Mac issue.
@peterHoburg peterHoburg changed the title #81 Some tests need to be skipped on ARM because there are no docker … Fix tests failing on ARM MacOS May 21, 2025
@peterHoburg peterHoburg changed the title Fix tests failing on ARM MacOS fix: tests failing on ARM MacOS May 21, 2025
@peterHoburg peterHoburg marked this pull request as ready for review May 22, 2025 18:26
Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofin cofin merged commit 5ba7b2d into litestar-org:main May 24, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Contributing: Tests fail on M series MacOS.

2 participants