Add support for Machdyne Kolsch - #679
Merged
Merged
Conversation
trabucayre
reviewed
Jul 2, 2025
| Subsignal("ras_n", Pins("IO_SB_B5")), | ||
| Subsignal("cas_n", Pins("IO_SB_B3")), | ||
| Subsignal("we_n", Pins("IO_SB_A5")), | ||
| Subsignal("dq", Pins( |
trabucayre
reviewed
Jul 2, 2025
Comment on lines
+49
to
+51
| Subsignal("r", Pins("IO_NA_B1 IO_NA_A1 IO_NA_A2 IO_NA_A4")), | ||
| Subsignal("g", Pins("IO_NA_B4 IO_NA_A7 IO_NA_B7 IO_NA_B2")), | ||
| Subsignal("b", Pins("IO_NA_A3 IO_NA_A5 IO_NA_A6 IO_NA_A8")), |
trabucayre
reviewed
Jul 2, 2025
Comment on lines
+70
to
+71
| Subsignal("left", Pins("IO_NB_B0")), | ||
| Subsignal("right", Pins("IO_NB_A0")), |
trabucayre
reviewed
Jul 2, 2025
Comment on lines
+33
to
+36
| self.rst = Signal() | ||
| rst_n = Signal() | ||
| self.cd_sys = ClockDomain() | ||
| self.cd_sys_ps = ClockDomain() |
trabucayre
reviewed
Jul 2, 2025
Comment on lines
+94
to
+96
| sdrphy_cls = GENSDRPHY | ||
|
|
||
| self.sdrphy = sdrphy_cls(platform.request("sdram"), sys_clk_freq) |
Contributor
There was a problem hiding this comment.
Why not directly using GENSDRPHY ?
Contributor
Author
There was a problem hiding this comment.
Fixed this, was leftover from experimenting. Also aligned Pins and assignments.
Contributor
|
Applied. Thanks @mmicko ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one requires to be applied as well
enjoy-digital/litedram#366
enjoy-digital/litex#2274