-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable ALL for TARGET_CONTAINER #683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, have you tested this PR?
Hi @ispeakc0de Yes, I have tested. When I use a specific container name ("hello-world-2"), I see in the logs that specific container being targeted:
When I use "ALL" for the container name, I see both the containers in the pod being selected:
|
@MichaelMorrisEst can you please rebase the branch? |
Signed-off-by: MichaelMorris <[email protected]>
651ac64
to
7bec239
Compare
No problem @neelanjan00 , rebased there now |
@ispeakc0de are we good to merge? |
What this PR does / why we need it:
Enables the user to specify ALL for TARGET_CONTAINERS to execute against all containers in the pods in parallel execution
Which issue this PR fixes
Closes #682
Special notes for your reviewer:
Checklist:
breaking-changes
tagrequires-upgrade
tag