fix: resolve pre-existing compilation errors in redfish and gcp libs#790
Open
mihir-dixit2k27 wants to merge 1 commit intolitmuschaos:masterfrom
Open
fix: resolve pre-existing compilation errors in redfish and gcp libs#790mihir-dixit2k27 wants to merge 1 commit intolitmuschaos:masterfrom
mihir-dixit2k27 wants to merge 1 commit intolitmuschaos:masterfrom
Conversation
Signed-off-by: Mihir Dixit <dixitmihir1@gmail.com>
mihir-dixit2k27
requested review from
ispeakc0de,
ksatchit and
uditgaurav
as code owners
Author
|
Observation regarding CI Failure: I noticed the Trivy security scan failed with exit code 1. I have verified that my changes are strictly limited to logic fixes in redfish.go and gcp-vm-instance-stop-by-label.go. I have not modified go.mod, go.sum, or the Dockerfile, so this PR does not introduce any new dependencies or version changes. This appears to be an infrastructure flake or a pre-existing baseline issue unrelated to this patch. Could a maintainer please re-trigger the workflow? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves critical pre-existing compilation errors and logging panics identified within the redfish and gcp libraries of the litmus-go repository. These issues were discovered during the environment setup phase and prevent the successful building of several experiment packages.
Key Changes:
Redfish Library: Corrected a log.Errorf call in pkg/baremetal/redfish/redfish.go that was missing the required %v format verb, which would lead to malformed logs or potential runtime issues.
GCP Library: Fixed a stacktrace.Propagate call in chaoslib/litmus/gcp-vm-instance-stop-by-label/lib/gcp-vm-instance-stop-by-label.go that was missing its mandatory error message argument, causing a compilation failure.
Which issue this PR fixes: N/A (Discovered during local development/build verification)
I have isolated these fixes from my main feature branch to maintain a clean and focused commit history. All changes were verified by running go build ./... on the affected directories to ensure they now compile successfully.