fix(litmus-agent): render preinstall RBAC only when preinstall job is true#490
Open
arunkumar-1992 wants to merge 1 commit into
Open
Conversation
… enabled Signed-off-by: arunkumar-1992 <111547359+arunkumar-1992@users.noreply.github.com>
arunkumar-1992
requested review from
Jonsy13,
Saranya-jena,
imrajdas,
ispeakc0de and
ksatchit
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR scopes the litmus-agent pre-install RBAC resources (ServiceAccount, Role, RoleBinding) to the same toggle as the pre-install registration job by wrapping them with enablePreInstallJob,
so when the job is disabled these resources are not rendered, and when enabled (default behavior) the flow remains unchanged; this reduces unnecessary resource creation in standalone/no-ChaosCenter installs without altering the default install path.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
DCO signed
Chart Version bumped
Variables are documented in the README.md