Skip to content

fix: Update project state logic to correctly handle user roles and de… #5386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hxrshxz wants to merge 6 commits into
base: master
Choose a base branch
from
+11 −3
Open

fix: Update project state logic to correctly handle user roles and de… #5386

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
af7cdb2
fix: Update project state logic to correctly handle user roles and de…
hxrshxz Jan 8, 2026
05f9099
fixes
hxrshxz Jan 8, 2026
484ad5a
Merge branch 'master' into fix-project-disappear-5106
PriteshKiri Mar 17, 2026
7fc6e77
Merge branch 'master' into fix-project-disappear-5106
PriteshKiri Apr 8, 2026
17edfc7
Merge branch 'master' into fix-project-disappear-5106
PriteshKiri Apr 14, 2026
110bc41
Merge branch 'master' into fix-project-disappear-5106
PriteshKiri Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions chaoscenter/authentication/pkg/project/repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,11 +365,19 @@ func (r repository) UpdateProjectState(ctx context.Context, userID string, deact
{"members", bson.D{
{"$elemMatch", bson.D{
{"user_id", userID},
{"role", bson.D{
{"$eq", entities.RoleOwner},
{"role", entities.RoleOwner},
}},
}},
Comment on lines 366 to +370
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The owner-matching $elemMatch doesn’t include invitation status. Since project visibility elsewhere treats non-accepted invitations as inactive (see chaoscenter/authentication/api/utils/project_utils.go:104-121), consider adding invitation == Accepted (and likewise in the “other owner” $elemMatch) so only accepted owners keep a project from being marked removed.

Copilot uses AI. Check for mistakes.
{"members", bson.D{
{"$not", bson.D{
{"$elemMatch", bson.D{
{"user_id", bson.D{{"$ne", userID}}},
{"role", entities.RoleOwner},
{"deactivated_at", bson.D{{"$not", bson.D{{"$gt", int64(0)}}}}},
}},
}},
}}}
}},
}

update = bson.D{
{"$set", bson.D{
Expand Down
Loading