fix staticcheck warnings #191
Conversation
kartikaysaxena
requested review from
Jonsy13,
Saranya-jena and
SarthakJain26
as code owners
| // Helper function to check the presence of a string in a slice | ||
| func sliceContains(s []string, e string) bool { | ||
| for _, a := range s { | ||
| if a == e { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } | ||
|
|
There was a problem hiding this comment.
Removed it because the lint was complaining about unused helper function
| source := rand.NewSource(time.Now().UnixNano()) | ||
| randomGenerator := rand.New(source) |
There was a problem hiding this comment.
Changed because rand.Seed is deprecated as of now.
| @@ -45,7 +45,7 @@ func GetInfraList(c types.Credentials, pid string, request models.ListInfraReque | |||
| return InfraData{}, err | |||
| } | |||
|
|
|||
| bodyBytes, err := ioutil.ReadAll(resp.Body) | |||
| bodyBytes, err := io.ReadAll(resp.Body) | |||
There was a problem hiding this comment.
ioutil is deprecated in favour of io and os
Now all warnings seems to be resolved.
|
|
@deep-poharkar @Nageshbansal please review this PR |
|
Lgtm 🚀 |
|
looks good |
|
@kartikaysaxena can you please try to resolve the merge conflicts, we can take this PR in litmusctl 1.3.0 release |
kartikaysaxena
force-pushed
the
fix-dependencies
branch
3 times, most recently
from
ea2b541 to
9610e29
Compare
Signed-off-by: Kartikay <[email protected]>
kartikaysaxena
force-pushed
the
fix-dependencies
branch
from
9610e29 to
8d346af
Compare
Signed-off-by: Kartikay <[email protected]>
|
Hey @SarthakJain26, both my commits are signed off, and DCO is passing, but it is still showing that merging is blocked. Can you help with that? |
|
It's because the build pipeline is failing, here are the logs: |
Signed-off-by: Kartikay <[email protected]>
|
@kartikaysaxena looks like there's one merge conflict, can you try resolving that as well please |
Signed-off-by: Kartikay <[email protected]>
Signed-off-by: Kartikay <[email protected]>
Signed-off-by: Kartikay <[email protected]>
Signed-off-by: Kartikay <[email protected]>
|
Thanks @kartikaysaxena for fixing this 🚀 |
Fixes #190