scripts: added makefile target for linting the code#202
Open
kartikaysaxena wants to merge 1 commit into
Open
Conversation
Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
kartikaysaxena
requested review from
Jonsy13,
Saranya-jena and
SarthakJain26
as code owners
Contributor
|
hey, @kartikaysaxena the change is good but I think you misunderstood what i said. I wanted to automate the process when we commit. so before committing a check would run for ex. like fmt then we would further add more checks if necessary. This is still manual and does not solve the issue. We would use the |
SarthakJain26
approved these changes
Feb 29, 2024
Collaborator
|
@shivam-Purohit is it resolved by pre-commit hooks now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #196, this is primarily for contributors to ensure their code doesn't have any linting issues and can conveniently check by running
make format_and_lint, it will also ensure this issue doesn't repeat in the future.We may also add this to documentation for contributors to run this before creating a PR.