Skip to content

refactor: value stored to 'diff' is never read#1109

Merged
geky merged 1 commit intolittlefs-project:develfrom
Ryan-CW-Code:never_read
Jun 30, 2025
Merged

refactor: value stored to 'diff' is never read#1109
geky merged 1 commit intolittlefs-project:develfrom
Ryan-CW-Code:never_read

Conversation

@Ryan-CW-Code
Copy link
Copy Markdown
Contributor

No description provided.

@geky-bot
Copy link
Copy Markdown
Collaborator

Tests passed ✓, Code: 17104 B (+0.0%), Stack: 1448 B (+0.0%), Structs: 812 B (+0.0%)
Code Stack Structs Coverage
Default 17104 B (+0.0%) 1448 B (+0.0%) 812 B (+0.0%) Lines 2434/2594 lines (+0.0%)
Readonly 6230 B (+0.0%) 448 B (+0.0%) 812 B (+0.0%) Branches 1283/1616 branches (+0.0%)
Threadsafe 17956 B (+0.0%) 1448 B (+0.0%) 820 B (+0.0%) Benchmarks
Multiversion 17176 B (+0.0%) 1448 B (+0.0%) 816 B (+0.0%) Readed 29369693876 B (+0.0%)
Migrate 18768 B (+0.0%) 1752 B (+0.0%) 816 B (+0.0%) Proged 1482874766 B (+0.0%)
Error-asserts 17916 B (+0.0%) 1440 B (+0.0%) 812 B (+0.0%) Erased 1568888832 B (+0.0%)

@geky
Copy link
Copy Markdown
Member

geky commented Jun 1, 2025

Interesting, I wonder why this wasn't caught with GCC -pedantic -Wall -Wextra.

Will bring this in on the next patch release, thanks for the PR!

@geky geky added the next patch label Jun 1, 2025
@Ryan-CW-Code
Copy link
Copy Markdown
Contributor Author

I also used clang-tidy and cppcheck

@geky geky changed the base branch from master to devel June 30, 2025 16:37
@geky geky merged commit 25b9a4a into littlefs-project:devel Jun 30, 2025
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants