Skip to content

fix: false uninitialized read warning #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geky merged 2 commits into from
Sep 29, 2025
Merged

fix: false uninitialized read warning #1133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c7b6b2
fix: false uninitialized read warning
elupus Aug 12, 2025
11cecd0
fix: also assert inside lfs_bd_read
elupus Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lfs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ static int lfs_bd_read(lfs_t *lfs,
// bypass cache?
diff = lfs_aligndown(diff, lfs->cfg->read_size);
int err = lfs->cfg->read(lfs->cfg, block, off, data, diff);
LFS_ASSERT(err <= 0);
if (err) {
return err;
}
Expand Down Expand Up @@ -739,6 +740,7 @@ static lfs_stag_t lfs_dir_getslice(lfs_t *lfs, const lfs_mdir_t *dir,
int err = lfs_bd_read(lfs,
NULL, &lfs->rcache, sizeof(ntag),
dir->pair[0], off, &ntag, sizeof(ntag));
LFS_ASSERT(err <= 0);
if (err) {
return err;
}
Expand Down Expand Up @@ -767,6 +769,7 @@ static lfs_stag_t lfs_dir_getslice(lfs_t *lfs, const lfs_mdir_t *dir,
err = lfs_bd_read(lfs,
NULL, &lfs->rcache, diff,
dir->pair[0], off+sizeof(tag)+goff, gbuffer, diff);
LFS_ASSERT(err <= 0);
if (err) {
return err;
}
Expand Down