fix(server): Reject invalid wf_run_id in RunWfRequest
#1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snarr
changed the title
wf_spec_name in RunWfRequestwf_run_id in RunWfRequest
coltmcnealy-lh
approved these changes
Feb 21, 2025
| throw new LHApiException(Status.INVALID_ARGUMENT, "Missing required parameter 'wf_spec_name'"); | ||
| } | ||
|
|
||
| if (!req.getId().equals("") && !LHUtil.isValidLHName(req.getId())) { |
There was a problem hiding this comment.
I wouldn't check for req.getId().equals(""). Instead, use the protobuf optional capability which checks for presence of the string. The way to do that is: req.hasId().
I would also suggest adding this:
if (req.hasId() && req.getId().equals("")) throw new LHApiException(...);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
RunWfRequestwf_run_idagainst theLHUtil.isValidLHName()method in both the API layer and the process layer.Resolves #1315