[lib][uefi] Fix memory leak in load_pe_file #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schultetwin1
approved these changes
Sep 3, 2025
Contributor
schultetwin1
left a comment
schultetwin1
left a comment
There was a problem hiding this comment.
One small change but looks good
| if (!dev) { | ||
| printf("error opening block device %s\n", blkdev); | ||
| return -1; | ||
| return ERR_IO; |
Contributor
There was a problem hiding this comment.
The only reason bio_open will return NULL is due to ERR_NOT_FOUND, so let's change this.
Suggested change
| return ERR_IO; | |
| return ERR_NOT_FOUND; |
zhangxp1998
force-pushed
the
master
branch
3 times, most recently
from
03f8336 to
3e73cb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.