Original identities not respected in ATAC analysis #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that unlike RNA analysis, the original identities aren't assigned to the Seurat object when using `ATACRunSeurat`. I propose to add the same behaviour where: - The `orig.ident` is assigned to to `SeuratObject` - The UMAP plot coloured by the `orig.ident` is saved There was also a minor discrepancy in the param name: `orig.ident` in RNA and ``orign.ident` in the ATAC function.
Author
|
@DongqingSun96 @baigal628 does this look fine to you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that unlike RNA analysis, the original identities aren't assigned to the Seurat object when using
ATACRunSeurat. I propose to add the same behaviour where:orig.identis assigned to toSeuratObjectorig.identis savedThere was also a minor discrepancy in the param name:
orig.identin RNA andorign.identin the ATAC function.