Fix test failing because of concurrent compilation - #3031
Merged
Conversation
josevalim
approved these changes
Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we remove Livebook storage file in
config/test.exs, so that it is fresh for every tests run and happens before the app boots.The issue with this approach is that while the tests are running, a concurrent compilation removes the files and makes all the tests fail. Most commonly it happens when you save a file during tests run, which causes the language server to recompile.
Doing this in
test_helpers.exsis too late because the app is started, and the startup uses the storage. I think a reasonable middle ground is doing it conditionally onApplication.start.