Improve integration tests and fix some intemittent tests - #3033
Conversation
|
Last comment, otherwise looks good to me :) |
|
There's still a test that fails everytime you run with integration tests: I tried the approach to send individual messages only for test env and only to a certain topic and it still intemittent due to concurrency. |
|
@aleDsz the issue is that in that test we expect only one permanent app: livebook/test/livebook/apps/manager_test.exs Lines 124 to 128 in f23d41a however there are leftover Team hubs from other tests and some of them have app deployments, so there are extra statuses in the list. Normally we could relax the assertions to I figured the best solution is to make sure there are no leftover Team hubs in the first place, so I added |
josevalim
left a comment
There was a problem hiding this comment.
I am happy. If @jonatanklosko is happy, we can ship it!
No description provided.