Skip to content

feat: add fish audio plugin#1382

Open
davidzhao wants to merge 1 commit intomainfrom
dz/fishaudio
Open

feat: add fish audio plugin#1382
davidzhao wants to merge 1 commit intomainfrom
dz/fishaudio

Conversation

@davidzhao
Copy link
Copy Markdown
Member

also added support for autoloading .env.local in dev mode

also added support for autoloading .env.local in dev mode
@davidzhao davidzhao requested review from toubatbrian and u9g May 4, 2026 06:34
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 6 additional findings.

Open in Devin Review

Comment thread agents/src/cli.ts
Comment on lines +16 to +42
const loadDotenvLocal = () => {
const path = resolve(process.cwd(), '.env.local');
let raw: string;
try {
raw = readFileSync(path, 'utf8');
} catch {
return;
}

let loadedCount = 0;
for (const rawLine of raw.split(/\r?\n/)) {
const line = rawLine.trim();
if (!line || line.startsWith('#')) continue;
const eq = line.indexOf('=');
if (eq <= 0) continue;
const key = line.slice(0, eq).trim();
if (!/^[A-Za-z_][A-Za-z0-9_]*$/.test(key)) continue;
let value = line.slice(eq + 1).trim();
if (
(value.startsWith('"') && value.endsWith('"')) ||
(value.startsWith("'") && value.endsWith("'"))
) {
value = value.slice(1, -1);
} else {
// strip trailing inline comment when value is unquoted
const hash = value.indexOf(' #');
if (hash !== -1) value = value.slice(0, hash).trimEnd();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use the library instead of building the toolkit ourselves? Below are code used by agent-starter-node

import dotenv from 'dotenv';

dotenv.config({ path: '.env.local' });

@@ -0,0 +1,7 @@
---
"@livekit/agents": minor
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be patch

@@ -0,0 +1,8 @@
---
"@livekit/agents-plugin-fishaudio": minor
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants