Skip to content

chore: remove unused TTS/STT type aliases in api_protos - #2555

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-tts-stt-type-aliases-in-api-pr-bd3bfc
Open

detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-tts-stt-type-aliases-in-api-pr-bd3bfc

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Description

Removed 21 unused export type X = z.infer<typeof xxxSchema> aliases from agents/src/inference/api_protos.ts — 13 TTS aliases and 8 STT aliases. The underlying Zod schemas are retained (still composed into the consumed union schemas); only the orphaned type-only exports are removed.

Changes Made

  • Removed 13 TTS type aliases (TtsGenerationConfig, TtsSessionCreateEvent, TtsInputTranscriptEvent, TtsSessionFlushEvent, TtsSessionCloseEvent, TtsSessionCreatedEvent, TtsOutputAudioEvent, TtsWordTimestamp, TtsCharTimestamp, TtsOutputAlignmentEvent, TtsDoneEvent, TtsSessionClosedEvent, TtsErrorEvent).
  • Removed 8 STT type aliases (SttWord, SttStartOfSpeechEvent, SttSessionCreatedEvent, SttSessionFinalizedEvent, SttSessionClosedEvent, SttErrorEvent, SttKnownServerEvent, SttUnknownServerEvent).

Pre-Review Checklist

  • Build passes: All builds (lint, typecheck, tests) pass locally
  • AI-generated code reviewed: Removed unnecessary comments and ensured code quality
  • Changes explained: All changes are properly documented and justified above
  • Scope appropriate: All changes relate to the PR title, or explanations provided for why they're included
  • Video demo: N/A (type-only dead code removal)

Testing

  • Automated tests added/updated (if applicable) — no test changes needed; removed symbols had zero test references
  • All tests pass (pnpm vitest run for inference: 17 files, 283 passed)
  • pnpm build, pnpm typecheck, pnpm lint, and pnpm api:check (api-extractor) all pass

Additional Notes

These aliases were dead: they had zero references anywhere in the codebase (agents, plugins, examples, tests) and were not re-exported through any barrel file or included in the package's public API surface (their containing schema siblings remain exported). Behavior and runtime outputs are unchanged — this is a pure type-only removal. Each removed alias is trivially recreatable via z.infer<typeof xxxSchema> if a future consumer needs it.

AI tooling used: Detail: Dead Code

History


Dead Code PRs can be configured here.

@detail-app
detail-app Bot requested a review from a team as a code owner September 22, 2026 00:25
@changeset-bot

changeset-bot Bot commented Sep 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1fb9c8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants