chore: remove unused TTS/STT type aliases in api_protos - #2555
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed 21 unused
export type X = z.infer<typeof xxxSchema>aliases fromagents/src/inference/api_protos.ts— 13 TTS aliases and 8 STT aliases. The underlying Zod schemas are retained (still composed into the consumed union schemas); only the orphaned type-only exports are removed.Changes Made
TtsGenerationConfig,TtsSessionCreateEvent,TtsInputTranscriptEvent,TtsSessionFlushEvent,TtsSessionCloseEvent,TtsSessionCreatedEvent,TtsOutputAudioEvent,TtsWordTimestamp,TtsCharTimestamp,TtsOutputAlignmentEvent,TtsDoneEvent,TtsSessionClosedEvent,TtsErrorEvent).SttWord,SttStartOfSpeechEvent,SttSessionCreatedEvent,SttSessionFinalizedEvent,SttSessionClosedEvent,SttErrorEvent,SttKnownServerEvent,SttUnknownServerEvent).Pre-Review Checklist
Testing
pnpm vitest runfor inference: 17 files, 283 passed)pnpm build,pnpm typecheck,pnpm lint, andpnpm api:check(api-extractor) all passAdditional Notes
These aliases were dead: they had zero references anywhere in the codebase (agents, plugins, examples, tests) and were not re-exported through any barrel file or included in the package's public API surface (their containing schema siblings remain exported). Behavior and runtime outputs are unchanged — this is a pure type-only removal. Each removed alias is trivially recreatable via
z.infer<typeof xxxSchema>if a future consumer needs it.AI tooling used: Detail: Dead Code
History
Dead Code PRs can be configured here.