-
Notifications
You must be signed in to change notification settings - Fork 250
fix(ci): unbreak Dart Format and Dart Analyze on main #1181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cd9dc0c
Format the repo scripts
hiroshihorie 129e91b
Await the cached-token future inside CachingTokenSource.fetch
hiroshihorie 43e07d9
Add changeset for CachingTokenSource await fix
hiroshihorie a2ae291
Commit the analyzer excludes Flutter's migrator insists on
hiroshihorie e5bc639
Keep the web/ E2EE sources under analysis
hiroshihorie 4f448eb
Shorten changeset entry
hiroshihorie ff50863
Mirror the root linter rules into the web analysis config
hiroshihorie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| patch type="fixed" "CachingTokenSource.fetch now awaits its result, so errors surface and the in-flight entry is cleared correctly" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| #!/usr/bin/env dart | ||
|
|
||
| /* | ||
| * Copyright 2025 LiveKit | ||
| * | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| #!/usr/bin/env dart | ||
|
|
||
| /* | ||
| * Copyright 2025 LiveKit | ||
| * | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| #!/usr/bin/env dart | ||
|
|
||
| /* | ||
| * Copyright 2025 LiveKit | ||
| * | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| # | ||
| # Copyright 2025 LiveKit | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # The repository-root analysis_options.yaml has to exclude `web/**`: Flutter's | ||
| # AnalysisOptionsMigration appends that pattern on every `flutter analyze` and | ||
| # offers no way to opt out. These files are real Dart source (the E2EE worker), | ||
| # not web assets, so this file gives them their own analysis context and keeps | ||
| # them covered. CI analyzes them via `dart analyze web/`. | ||
|
|
||
| include: package:lints/recommended.yaml | ||
|
|
||
| analyzer: | ||
| errors: | ||
| constant_identifier_names: ignore | ||
| use_super_parameters: ignore | ||
| avoid_print: ignore | ||
| deprecated_member_use_from_same_package: ignore | ||
|
|
||
| linter: | ||
| rules: | ||
| # Preference of the SDK | ||
| prefer_single_quotes: true | ||
| prefer_final_locals: true | ||
| unnecessary_brace_in_string_interps: false | ||
| avoid_print: true | ||
|
|
||
| # Enforce this for correct async logic | ||
| unawaited_futures: true | ||
| discarded_futures: true | ||
|
|
||
| formatter: | ||
| page_width: 120 | ||
| trailing_commas: preserve | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.