fix(shadcn): respect message-scroller default scrollPreviousItemPeek#1396
Merged
Merged
Conversation
AgentChatTranscript was overriding scrollPreviousItemPeek to 20px, shadowing the primitive's own default of 64px. Removing the override lets callers rely on the upstream default unless they explicitly opt into a custom value. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
size-limit report 📦
|
1egoman
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
No linked Linear ticket.
Overview
AgentChatTranscripthardcodedscrollPreviousItemPeekto20px, silently overridingmessage-scroller's own default of64px.Testing
pnpm vitest run tests/agent-chat-transcript.test.tsx— 6/6 passing.AgentChatTranscriptstories) that scroll-anchor peek spacing looks correct using the upstream default.