chore(import): mixer and ringbuf from sip - #19
Merged
Merged
Conversation
milos-lk
reviewed
Sep 17, 2025
| @@ -0,0 +1,152 @@ | |||
| package ringbuf | |||
Contributor
There was a problem hiding this comment.
minor: do we want copyright notice for these?
milos-lk
approved these changes
Sep 17, 2025
dennwc
reviewed
Sep 17, 2025
| "github.com/frostbyte73/core" | ||
| msdk "github.com/livekit/media-sdk" | ||
|
|
||
| "github.com/livekit/media-sdk/internal/ringbuf" |
Collaborator
There was a problem hiding this comment.
We could move it from internal now, I think. We didn't want anyone using these packages by importing SIP, but here it would be appropriate.
| const ( | ||
| // inputBufferFrames sets max number of frames that each mixer input will allow. | ||
| // Sending more frames to the input will cause old one to be dropped. | ||
| inputBufferFrames = 5 |
Collaborator
There was a problem hiding this comment.
These are reasonable values for SIP, but we probably want it configurable.
|
Just out of curiosity - why do we need another implementation of ring buffer, if we already have it either in go's std. library: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.