feat: configurable mixer input buffer frames, public ringbuf - #20
Merged
Conversation
boks1971
approved these changes
Sep 18, 2025
|
If you ask me, I would name the package Just out of curiosity - why a new implementation of ring buffer (instead of using this one from go's std. library or from backend-commons)? |
dennwc
approved these changes
Sep 18, 2025
Collaborator
|
Agree @kuba-- , good point regarding the naming. |
Collaborator
|
As for "why", I think both implementation had some assumptions that were not true for SIP. It either assumes large object pointers instead of arrays of samples or doesn't have the methods we need. I can recall specifics later if you want. There should be an old PR to SIP which has exactly the same question answered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.