Skip to content

Ignoring shutdown-related errors while in discard loop #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexlivekit merged 1 commit into from
Mar 18, 2026
Merged

Ignoring shutdown-related errors while in discard loop #623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions pkg/sip/media_port.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,14 +251,19 @@ func (c *udpConn) discardLoop() error {
for !c.stopping.IsBroken() {
err = c.UDPConn.SetReadDeadline(time.Now().Add(rtp.DefFrameDur))
if err != nil {
c.log.Warnw("error encountered while setting read deadline", err)
if !errors.Is(err, net.ErrClosed) {
c.log.Warnw("error encountered while setting read deadline", err)
}
break
}
_, _, err = c.ReadFromUDPAddrPort(buf)
if errors.Is(err, os.ErrDeadlineExceeded) {
continue
}
if err != nil {
if errors.Is(err, os.ErrDeadlineExceeded) {
continue
}
if errors.Is(err, net.ErrClosed) {
break
}
c.log.Warnw("error encountered while reading UDP packets", err)
break
}
Expand All @@ -268,7 +273,7 @@ func (c *udpConn) discardLoop() error {
c.log.Infow("Stopped discarding packets", "packetsDiscarded", packetsDiscarded, "error", err)
}
err = c.UDPConn.SetReadDeadline(time.Time{}) // clear deadline
if err != nil {
if err != nil && !errors.Is(err, net.ErrClosed) {
c.log.Warnw("error encountered while clearing read deadline", err)
}
return err
Expand Down
Loading