Skip to content

Refactoring reinvite tests, adding transfer tests #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexlivekit merged 3 commits into from
Mar 24, 2026
Merged

Refactoring reinvite tests, adding transfer tests #630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97016d7
wow, tests helped
alexlivekit Mar 21, 2026
d4fe231
minor touch
alexlivekit Mar 23, 2026
d2cdba9
PR comment (nice catch @He!)
alexlivekit Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
258 changes: 0 additions & 258 deletions pkg/sip/inbound_process_invite_test.go
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion pkg/sip/outbound.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,6 @@ func (c *outboundCall) Disconnected() <-chan struct{} {
}

func (c *outboundCall) Close(ctx context.Context) error {
c.closing.Break()
c.mu.Lock()
defer c.mu.Unlock()
c.close(ctx, nil, callDropped, "shutdown", livekit.DisconnectReason_SERVER_SHUTDOWN)
Expand All @@ -306,6 +305,7 @@ func (c *outboundCall) printStats() {
}

func (c *outboundCall) close(ctx context.Context, err error, status CallStatus, description string, reason livekit.DisconnectReason) {
c.closing.Break()
ctx = context.WithoutCancel(ctx)
c.stopped.Once(func() {
c.stats.Closed.Store(true)
Expand Down
Loading
Loading