TEL-477: associate processors with callID - #647
Merged
Merged
Conversation
hechen-eng
force-pushed
the
krisp_improve
branch
from
April 1, 2026 22:35
6e52e47 to
eac4b19
Compare
alexlivekit
approved these changes
Apr 1, 2026
alexlivekit
left a comment
alexlivekit
left a comment
Contributor
There was a problem hiding this comment.
Approving, but please use the source of the info - c.cc.ID() rather than auxillary state/callInfo objects.
alexlivekit
reviewed
Apr 2, 2026
| c.log().Debugw("SDP answer", "sdp", string(answerData)) | ||
|
|
||
| mconf.Processor = c.s.handler.GetMediaProcessor(features, featureFlags) | ||
| mconf.Processor = c.s.handler.GetMediaProcessor(features, featureFlags, c.call.LkCallId) |
Contributor
There was a problem hiding this comment.
@hechen-eng , c.cc.ID is the source of the call ID. Please include this in some follow-up PR (doesn't need to be dedicated to this)
Contributor
Author
There was a problem hiding this comment.
um.. sorry for missing the inbound. Addressing it in #643
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.