Remove cache from 'Release to Docker' workflow as unused - #681
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
==========================================
- Coverage 65.25% 65.20% -0.05%
==========================================
Files 51 40 -11
Lines 6588 7306 +718
==========================================
+ Hits 4299 4764 +465
- Misses 1915 2083 +168
- Partials 374 459 +85 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hey @davidzhao spare a moment to review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest execution of this workflow did not leverage a cache - https://github.com/livekit/sip/actions/runs/24797926357/job/72572555591#step:3:15
Due to frequent cache creations from other workflows, caches are often evicted as noted on https://github.com/livekit/sip/actions/caches
Along with the infrequent executions of the 'Release to Docker' workflow, any cache created would likely be evicted before it could be utilized. So, proposing removing the cache step from the 'Release to Docker' workflow as unused.
Closes #433.