Correctly use codec names, fix deps.#713
Merged
Merged
Conversation
hechen-eng
approved these changes
Jun 8, 2026
kannanmaran
pushed a commit
to kannanmaran/livekitsip
that referenced
this pull request
Jun 9, 2026
Picks up the media-sdk dependency bump and codec-name constant rename from livekit#713 ("Correctly use codec names, fix deps"). Conflict resolved in pkg/sip/media_codecs.go: keep livekit#713's renamed *SDPNameAndRate map keys and retain the opt-in Opus entry (OpusSDPName: false). Updated Opus test files to the new *SDPNameAndRate constants. Opus remains disabled by default; no behavior change to existing codecs, SIP negotiation, or WebRTC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.