livepeer_cli: Fix the "ERROR: logging before flag.Parse" warning when any option is selected #2445
Conversation
emranemran
force-pushed
the
user/emahbub/fix-glog-warning-in-livepeer-cli
branch
from
9c9e3cd to
2c0b72a
Compare
emranemran
force-pushed
the
user/emahbub/fix-glog-warning-in-livepeer-cli
branch
from
2c0b72a to
9acf875
Compare
Codecov Report
@@ Coverage Diff @@
## master #2445 +/- ##
=============================================
Coverage 55.02775% 55.02775%
=============================================
Files 94 94
Lines 19641 19641
=============================================
Hits 10808 10808
Misses 8236 8236
Partials 597 597
Continue to review full report at Codecov.
|
any option is selected As part of commit 78789b1 (Issue #928), the call to flag.Parse() was commented out perhaps unintentionally. This call is required prior to using glog calls as noted here: https://github.com/golang/glog/blob/master/glog.go#L40
emranemran
force-pushed
the
user/emahbub/fix-glog-warning-in-livepeer-cli
branch
from
9acf875 to
d9f4af8
Compare
| @@ -58,7 +59,7 @@ func main() { | |||
| return nil | |||
| } | |||
| app.Version = core.LivepeerVersion | |||
| // flag.Parse() | |||
| flag.Parse() | |||
There was a problem hiding this comment.
I think that we cannot parse flags here, because they need to be parsed in Urfave CLI framework.
I think after your change, the flags won't work. Please check if the following works for you.
./livepeer_cli -http 7937
There was a problem hiding this comment.
Yep, you're right. Silly of me to not realize this before opening up for review - will revisit the CLI framework and fix this PR.
|
Ask @emranemran to merge this item. |
As part of commit 78789b1 (Issue #928), the call to flag.Parse() was commented out perhaps unintentionally. This call is required prior to using glog calls as noted here:
https://github.com/golang/glog/blob/master/glog.go#L40
What does this pull request do? Explain your changes. (required)
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Fix #2186
Checklist:
makeruns successfully./test.shpass