Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livepeer_cli: Fix the "ERROR: logging before flag.Parse" warning when any option is selected #2445

Closed
wants to merge 1 commit into from
Closed

livepeer_cli: Fix the "ERROR: logging before flag.Parse" warning when any option is selected #2445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG_PENDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@

#### CLI
- \#2438 Add new menu option to gracefully exit livepeer_cli (@emranemran)
- \#2186 Fix the "ERROR: logging before flag.Parse" warning when any option is selected (@emranemran)

#### General

Expand Down
3 changes: 2 additions & 1 deletion cmd/livepeer_cli/livepeer_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package main

import (
"bufio"
"flag"
"fmt"
"math/rand"
"net/http"
Expand Down Expand Up @@ -58,7 +59,7 @@ func main() {
return nil
}
app.Version = core.LivepeerVersion
// flag.Parse()
flag.Parse()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we cannot parse flags here, because they need to be parsed in Urfave CLI framework.

I think after your change, the flags won't work. Please check if the following works for you.

./livepeer_cli -http 7937

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, you're right. Silly of me to not realize this before opening up for review - will revisit the CLI framework and fix this PR.

app.Run(os.Args)
}

Expand Down