Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ai/live: Add unit tests for MediaReader / MediaWriter #3466

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

j0sh
Copy link
Collaborator

@j0sh j0sh commented Mar 25, 2025

Mostly done to increase confidence around #3447

@j0sh j0sh requested review from victorges, leszko and mjh1 March 25, 2025 00:18
@github-actions github-actions bot added the go Pull requests that update Go code label Mar 25, 2025
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.37938%. Comparing base (d543d17) to head (20cb3da).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3466         +/-   ##
===================================================
+ Coverage   30.31420%   30.37938%   +0.06518%     
===================================================
  Files            151         151                 
  Lines          44494       44494                 
===================================================
+ Hits           13488       13517         +29     
+ Misses         30219       30187         -32     
- Partials         787         790          +3     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d543d17...20cb3da. Read the comment docs.

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j0sh j0sh enabled auto-merge (squash) March 25, 2025 17:11
@j0sh j0sh merged commit 2135404 into master Mar 25, 2025
16 checks passed
@j0sh j0sh deleted the ja/mediawriter-tests branch March 25, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants