Skip to content

Navigation patterns guide#1391

Draft
BrooklinJazz wants to merge 65 commits intomainfrom
navigation-patterns-guide
Draft

Navigation patterns guide#1391
BrooklinJazz wants to merge 65 commits intomainfrom
navigation-patterns-guide

Conversation

@BrooklinJazz
Copy link
Copy Markdown
Contributor

@BrooklinJazz BrooklinJazz commented Jul 18, 2024 •
edited
Loading

There is an issue blocking this PR.
The stylesheet doesn't recompile when changing the navigationTitle modifier.

Reproduction Steps

  • Open the livebooks/navigation_cookbook.livemd livebook. Run the Livebook.
  • Change the value of the navigation title in the code example from "OK" to "Hello" (or any other value) to reproduce the issue
  • Notice that even after 5 seconds, the stylesheet at http://localhost:4000/assets/app.swiftui.styles does not change.

BrooklinJazz and others added 30 commits April 30, 2024 13:20
@BrooklinJazz
Introduce v0.3.0 livebook guides
a772d33
@BrooklinJazz
add pretty: true config to live_view_native_stylesheet in livebook le…
2c70332 
…ssons
@BrooklinJazz
move livebooks
a01e782
@BrooklinJazz
Draft forms and validations reading
df47852
@BrooklinJazz
grammar check create a swiftui app
667df60
@BrooklinJazz
grammar check getting started
d20310e
@BrooklinJazz
grammar check swiftui views
e037da6
@BrooklinJazz
Use flags to control mix docs tasks and generate markdown livebooks
9e85aed
@BrooklinJazz
Merge branch 'main' into v0.3.0-guides
aeca50f
@BrooklinJazz
Move form package setup to the create a swiftui application section
74be999
@BrooklinJazz
Fix examples in the interactive swiftui views reading to use LiveForm
898b762
@BrooklinJazz
remove unused check_errors value in the socket for forms and validati…
4232b5f 
…ons reading
@BrooklinJazz
update class -> style
fbaf75f
@BrooklinJazz
fix create a swiftui application bug
9a80909
@BrooklinJazz
use single quotes for Color syntax
452a903
@BrooklinJazz
add vscode to gitignore
aa54597
@BrooklinJazz
Draft syntax conversion cheatsheet
8e8d082
@BrooklinJazz
Replace html with heex
164aa39
@BrooklinJazz
Merge branch 'main' into v0.3.0-guides
eb18a57 
Signed-off-by: Brooklin Myers <brooklinjazzmyers@gmail.com>
@BrooklinJazz @carson-katri
Update livebooks/create-a-swiftui-application.livemd
897daf5 
Co-authored-by: Carson Katri <Carson.katri@gmail.com>
Signed-off-by: Brooklin Myers <brooklinjazzmyers@gmail.com>
@BrooklinJazz @carson-katri
Update livebooks/create-a-swiftui-application.livemd
dc28b2b 
Co-authored-by: Carson Katri <Carson.katri@gmail.com>
Signed-off-by: Brooklin Myers <brooklinjazzmyers@gmail.com>
@BrooklinJazz @carson-katri
Update livebooks/create-a-swiftui-application.livemd
3d806a4 
Co-authored-by: Carson Katri <Carson.katri@gmail.com>
Signed-off-by: Brooklin Myers <brooklinjazzmyers@gmail.com>
@BrooklinJazz
resolve PR review comments
89b3487
@BrooklinJazz @carson-katri
Update livebooks/stylesheets.livemd
ec906ff 
Co-authored-by: Carson Katri <Carson.katri@gmail.com>
Signed-off-by: Brooklin Myers <brooklinjazzmyers@gmail.com>
@BrooklinJazz @carson-katri
Update livebooks/native-navigation.livemd
e6e0c4b 
Co-authored-by: Carson Katri <Carson.katri@gmail.com>
Signed-off-by: Brooklin Myers <brooklinjazzmyers@gmail.com>
@BrooklinJazz @carson-katri
Update livebooks/forms-and-validation.livemd
caf8c19 
Co-authored-by: Carson Katri <Carson.katri@gmail.com>
Signed-off-by: Brooklin Myers <brooklinjazzmyers@gmail.com>
@BrooklinJazz @carson-katri
Update livebooks/forms-and-validation.livemd
29aa01e 
Co-authored-by: Carson Katri <Carson.katri@gmail.com>
Signed-off-by: Brooklin Myers <brooklinjazzmyers@gmail.com>
@BrooklinJazz @carson-katri
Update livebooks/forms-and-validation.livemd
a5028d0 
Co-authored-by: Carson Katri <Carson.katri@gmail.com>
Signed-off-by: Brooklin Myers <brooklinjazzmyers@gmail.com>
@BrooklinJazz
PR review changes
07da913
@BrooklinJazz
add config for physical devices
75c520c
carson-katri and others added 22 commits July 3, 2024 10:21
@carson-katri @BrooklinJazz
Remove <%!-- template --%> specifier
cc9a44b
@carson-katri @BrooklinJazz
Add support for AttributeReference in individual Color properties
cf2220e
@carson-katri @BrooklinJazz
Fix ShapeStyle tests
f2b05e1
@carson-katri @BrooklinJazz
Expose the document and updated NodeRef for addon libraries (#1373)
4720460
@carson-katri @BrooklinJazz
Split complex Regex expression (#1376)
2f91282
@bcardarella @BrooklinJazz
Bundle xcodegen
d662cf0
@carson-katri @BrooklinJazz
Skip stylesheet parsing if ContentBuilder doesn't provide any modifiers
356a932
@carson-katri @BrooklinJazz
Add nested keys for l10n and i18n
e71368e
@carson-katri @BrooklinJazz
Shorten keys
e1657d6
@BrooklinJazz
rebase from main
afa0f63
@BrooklinJazz
Use flags to control mix docs tasks and generate markdown livebooks
761f8e3
@BrooklinJazz
fix issues from rebase
e8682f0
@BrooklinJazz
Merge branch 'custom-color-test-branch' into v0.3.0-guides
7286d73
@BrooklinJazz
remove example code for brian
969991a
@BrooklinJazz
add attribute parsers section
849a7f8
@BrooklinJazz
use kino_live_view_native github url instead of local path
0460075
@BrooklinJazz
Introduce v0.3.0 livebook guides
e270a47
@BrooklinJazz
Use flags to control mix docs tasks and generate markdown livebooks
668b112
@BrooklinJazz
generate docs
f7a76b9
@BrooklinJazz
start navigation cookbook
4c28100
@BrooklinJazz
draft navigation patterns drill-down pattern
01f3dba
@BrooklinJazz
use kino_live_view_native github url instead of local path
038258e
@bcardarella bcardarella mentioned this pull request Aug 9, 2024
Closed
@bcardarella
Copy link
Copy Markdown
Collaborator

bcardarella commented Aug 12, 2024

is there anything more needed for this PR to merge?

@BrooklinJazz
Copy link
Copy Markdown
Contributor Author

BrooklinJazz commented Aug 12, 2024 •
edited
Loading

is there anything more needed for this PR to merge?

@carson-katri and I are working on this together. @carson-katri I sent you a DM about one of the examples being broken.

Right now this is on the back burner for me while I focus on the workshop and more critical issues. There are several more examples I want to add to the guide. Also, theres a lot of merge conflicts I'll need to fix.

@bcardarella
Copy link
Copy Markdown
Collaborator

bcardarella commented Sep 19, 2024

@BrooklinJazz why was this closed?

@bcardarella bcardarella reopened this Sep 19, 2024
@bcardarella bcardarella self-assigned this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bcardarella bcardarella

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BrooklinJazz @bcardarella @carson-katri