Fix button-or-div to allow button type to be changed #1168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scenario
Currently if you want to use a badge as a submit button, the button's type is set to
button
even if you pass intype="submit"
.The problem
The badge component is wrapped in the
button-or-div
component and the attributes are being correctly forwarded to it.But it turns out that the type on the button in the
button-or-div
component is hard coded, so can't be overridden with attributes.The solution
Change
button-or-div
button so that the type can be merged in through attributes.