-
Notifications
You must be signed in to change notification settings - Fork 2
Offload rerank scoring and remove unused helper #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded@ljt019 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 33 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThe changes refactor two components: the Qwen3 reranker model and the reranker pipeline. In the model, an unnecessary wrapper function was removed, simplifying the code. In the pipeline, the reranking process was offloaded to a blocking task using asynchronous execution, improving task management without altering public interfaces. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant RerankerPipeline
participant BlockingTask
participant Model
User->>RerankerPipeline: get_scores(query, documents)
RerankerPipeline->>BlockingTask: spawn_blocking (move model, tokenizer, query, docs)
BlockingTask->>Model: rerank(query, documents)
Model-->>BlockingTask: scores
BlockingTask-->>RerankerPipeline: scores (via JoinHandle)
RerankerPipeline-->>User: scores
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary
RerankPipeline::get_scoresQwen3RerankModelconstruction by removing redundantrerank_idhelperTesting
cargo test --libcargo test --doc(fails: doctest compilation errors)https://chatgpt.com/codex/tasks/task_e_686cd099b6048330bee945114c47fab2
Summary by CodeRabbit
Refactor
Bug Fixes