-
Notifications
You must be signed in to change notification settings - Fork 2
Fix reranker implementation with new code #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reranker implementation with new code #77
Conversation
Co-authored-by: lucienthomas00 <[email protected]>
|
Caution Review failedThe pull request is closed. WalkthroughThis update introduces a minimal internal implementation for the Qwen3 reranker model, including model architecture, GGUF quantized weight loading, and a revised relevance scoring logic. The scoring now compares logits for "yes" and "no" tokens directly, simplifying the previous token aggregation approach. Several new structs and methods are added for model components. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Qwen3RerankModel
participant Tokenizer
participant ModelWeights
User->>Qwen3RerankModel: compute_relevance_score(query, doc)
Qwen3RerankModel->>Tokenizer: encode(formatted_prompt, add_special_tokens=true)
Tokenizer-->>Qwen3RerankModel: token_ids
Qwen3RerankModel->>ModelWeights: forward(token_ids)
ModelWeights-->>Qwen3RerankModel: logits
Qwen3RerankModel->>Qwen3RerankModel: extract "yes" and "no" logits
Qwen3RerankModel-->>User: relevance_score = logits["yes"] - logits["no"]
Possibly related PRs
Suggested labels
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Clippy (1.86.0)error: failed to get Caused by: Caused by: Caused by: Caused by: 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Refactor Qwen3 reranker to use a minimal, working implementation for correct and faster relevance scoring.
Summary by CodeRabbit