Skip to content

Fix navigation through sessions and subpages#11

Merged
florian-h05 merged 3 commits intomainfrom
session-navigation
Mar 19, 2025
Merged

Fix navigation through sessions and subpages#11
florian-h05 merged 3 commits intomainfrom
session-navigation

Conversation

@FelixHertweck
Copy link
Copy Markdown
Member

Fix for navigation between open sessions and new sessions

If you change to the knowledge page and go back, the previous session is reopened

Copy link
Copy Markdown
Member

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
One question about the replace though.

Comment thread src/views/overlays/sidebar/SidebarMainNav.tsx Outdated
Comment thread src/lib/navigateToSession.ts Outdated
Copy link
Copy Markdown
Member

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 added the bug Something isn't working label Mar 19, 2025
@florian-h05 florian-h05 merged commit 8568b80 into main Mar 19, 2025
@florian-h05 florian-h05 deleted the session-navigation branch March 19, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants