Skip to content

Knowledge Status: Fix width of badge to auto adjust to content#13

Merged
FelixHertweck merged 1 commit intomainfrom
knowledge-ingestion-status-fix-width
Mar 20, 2025
Merged

Knowledge Status: Fix width of badge to auto adjust to content#13
FelixHertweck merged 1 commit intomainfrom
knowledge-ingestion-status-fix-width

Conversation

@florian-h05
Copy link
Copy Markdown
Member

@florian-h05 florian-h05 commented Mar 19, 2025

This fixes the issue where text of the knowledge status badge overflows the badge:

image

@florian-h05 florian-h05 added the bug Something isn't working label Mar 19, 2025
@florian-h05 florian-h05 force-pushed the knowledge-ingestion-status-fix-width branch from e416a32 to a6b287e Compare March 19, 2025 22:57
@florian-h05 florian-h05 changed the title Knowledge Ingestion Status: Fix width of badge to auto adjust to content Knowledge Status: Fix width of badge to auto adjust to content Mar 19, 2025
@FelixHertweck
Copy link
Copy Markdown
Member

Maybe it would be nice if all status fields had the same width, but I'm not sure if that's necessary

@florian-h05
Copy link
Copy Markdown
Member Author

That might be a bit difficult to implement as we don't know the max description length in advance and IMO it looks a bit awkward to have much empty space after the status description.

@FelixHertweck
Copy link
Copy Markdown
Member

Okay then, let's leave it at that

@FelixHertweck FelixHertweck merged commit 44edb12 into main Mar 20, 2025
@florian-h05 florian-h05 deleted the knowledge-ingestion-status-fix-width branch March 20, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants