feat: UX Colorize aspect ratios, landscape vs portrait #2926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It feels to me that this is crying out for a little bit of SVG magic to draw the aspect ratio next to each option. Or probably just some HTML/CSS. Though possibly the differences in aspect ration will be hard to see at this size. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found trying to guess if the Aspect Ration was landscape or portrait. Kept getting it wrong! As my computer is super old and slow, this bugged me.
My original idea was to split the manual in three, but that was a hassle to implement without changing a lot of things. This seemed pretty straight forward.
I'm so lazy I didn't add a key, but that would just create more work for localization and it's pretty clear
Screenshot
