Skip to content

Make sure script modules get added to sys.modules #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Make sure script modules get added to sys.modules #1614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion modules/script_loading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import os
import os, sys
import importlib.util

from modules import errors
Expand All @@ -10,6 +10,11 @@
def load_module(path):
module_spec = importlib.util.spec_from_file_location(os.path.basename(path), path)
module = importlib.util.module_from_spec(module_spec)
# see importlib docs, module must be added to sys.modules
# https://docs.python.org/3/library/importlib.html#examples
# See dicussion https://github.com/python/cpython/issues/81702
if module_spec.name not in sys.modules:
sys.modules[module_spec.name] = module
module_spec.loader.exec_module(module)

loaded_scripts[path] = module
Expand Down