add GGUF on Embedding layer #2963
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panchovix
added a commit
to Panchovix/stable-diffusion-webui-reForge
that referenced
this pull request
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some T5 quantification are quantizing the layer
enc.blk.0.attn_rel_b.weightit's supported by City96 in his comfy node https://github.com/city96/ComfyUI-GGUF/blob/main/ops.py#L251
but not in Forge, as only the
Linearclass is overriden inForgeOperationsGGUFin this PR, I add the
Embeddingwhich I keep as close as possible from the spirit of both theLinearofForgeOperationsGGUF, and theEmbeddingofForgeOperations.enc.blk.0.attn_rel_b.weightis not quantized. It was working before and it is still working.enc.blk.0.attn_rel_b.weightis quantized. It was not working beofre, it is working now !