fix(chart): make empty image-tag default resolve to a published tag (#277)#281
Open
shimib wants to merge 1 commit into
Open
fix(chart): make empty image-tag default resolve to a published tag (#277)#281shimib wants to merge 1 commit into
shimib wants to merge 1 commit into
Conversation
…lt resolves The publish script tagged released images with the git tag verbatim (e.g. v0.7.1) but stripped the leading 'v' from appVersion. The chart's recommended 'leave ap.image.tag empty' default falls back to .Chart.AppVersion, which then resolved to a nonexistent tag (0.7.1) instead of the published v0.7.1 -> ImagePullBackOff. Keep .version as bare SemVer (OCI/Helm requirement) but set .appVersion from the v-prefixed VERSION so the empty-tag default matches the image that is actually published. Fixes llm-d-incubation#277 Signed-off-by: Shimi Bandiel <shimib@google.com>
shimib
requested review from
RishabhSaini,
ahg-g,
evacchi and
jtechapps
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the appVersion / image-tag
v-prefix mismatch (#277).The release publish script (
scripts/publish-helm-chart.sh) tagged images with the git tag verbatim (e.g.v0.7.1) but stripped the leadingvwhen writingappVersion. The chart's recommended "leaveap.image.tagempty to track appVersion" default renders{{ .Values.ap.image.tag | default .Chart.AppVersion }}, so clearing the tag resolved toghcr.io/llm-d-incubation/llm-d-async:0.7.1— a tag that does not exist (onlyv0.7.1is published) →ImagePullBackOff.Fix
.versionas bare SemVer (OCI/Helm requirement)..appVersionfrom the v-prefixedVERSIONso the empty-tag default matches the published image.How was this tested?
Simulated the publish step (
yqmutations withVERSION=v0.7.1) and rendered the chart:version: 0.7.1,appVersion: "v0.7.1"...llm-d-async:v0.7.1...llm-d-async:v0.7.1(previously:0.7.1, broken)helm lintpassesRelated Issues
Fixes #277