Skip to content

Commit 3b6cee2

Browse files
MikeSpreitzerclaudeCopilot
committed
fix: wait for CRDs to be Established in OpenShift E2E workflow
Resolves #277. The previous check used `kubectl get crd` to verify CRD existence, which was redundant since a successful `kubectl apply` already guarantees that. What actually needs checking is that the CRDs become "Established", meaning the API servers have digested the definitions. Replace the existence checks with `kubectl wait --for=condition=Established` calls (120s timeout) for each of the FMA CRDs. Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 7eb291a commit 3b6cee2

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

.github/workflows/ci-e2e-openshift.yaml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -433,8 +433,10 @@ jobs:
433433
434434
- name: Apply FMA CRDs
435435
run: |
436+
CRD_NAMES=""
436437
for crd_file in config/crd/*.yaml; do
437438
crd_name=$(kubectl apply --dry-run=client -f "$crd_file" -o jsonpath='{.metadata.name}')
439+
CRD_NAMES="$CRD_NAMES $crd_name"
438440
if kubectl get crd "$crd_name" &>/dev/null; then
439441
echo " CRD $crd_name already exists, skipping"
440442
else
@@ -443,12 +445,13 @@ jobs:
443445
fi
444446
done
445447
446-
# Verify CRDs are registered
447-
echo "Verifying CRDs..."
448-
kubectl get crd inferenceserverconfigs.fma.llm-d.ai
449-
kubectl get crd launcherconfigs.fma.llm-d.ai
450-
kubectl get crd launcherpopulationpolicies.fma.llm-d.ai
451-
echo "All CRDs registered successfully"
448+
# Wait for CRDs to become Established (API servers have digested the definitions)
449+
echo "Waiting for CRDs to become Established..."
450+
CRD_TIMEOUT=120s
451+
for crd_name in $CRD_NAMES; do
452+
kubectl wait --for=condition=Established "crd/$crd_name" --timeout="$CRD_TIMEOUT"
453+
done
454+
echo "All CRDs established"
452455
453456
- name: Create ConfigMaps
454457
run: |

0 commit comments

Comments
 (0)