Add deploy_fma.sh and debug workflow for OCP E2E#357
Merged
diegocastanibm merged 9 commits intomainfrom Mar 19, 2026
Merged
Conversation
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
… not referenced elsewhere) - Remove hardcoded Helm values that duplicate chart defaults (global.local=false, dualPodsController.sleeperLimit=2, launcherPopulator.enabled=true, dualPodsController.debugAcceleratorMemory=false) - Add HELM_EXTRA_ARGS env var to allow callers to pass arbitrary --set flags to helm upgrade --install - Update workflow to pass --set dualPodsController.debugAcceleratorMemory=false via HELM_EXTRA_ARGS - Show both controller images (dual-pods-controller + launcher-populator) in deploy step output Signed-off-by: Diego-Castan <diego.castan@ibm.com>
Collaborator
|
@MikeSpreitzer, with the latest commits by @diegocastanibm, is this PR ready to be merged? Progress work for PR # 332 has dependency on this PR. |
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
MikeSpreitzer
approved these changes
Mar 19, 2026
Collaborator
MikeSpreitzer
left a comment
There was a problem hiding this comment.
LGTM (provided the Ci tests succeed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This is a companion to #332. As discussed in that PR, we split the E2E workflow into two scripts:
deploy_fma.sh(this PR) — deploys FMA infrastructure: CRDs, controllers (dual-pods + launcher-populator), test serviceaccount, test objects (ISC, LC, LPP, ReplicaSet), and verifies that pods are created, bound, and ready.
ocp-test.sh(Standardize how to Run E2E tests in the OCP Test Infrastructure #332) — runs the actual E2E test scenarios (wake-up fast path, CEL policy validation, etc.) using theobjects deployed by deploy_fma.sh.
Feature
--standaloneflag:By default,
deploy_fma.shassumes the CI workflow has already created the namespace and GHCR pull secret. When--standaloneis passed, the script handles namespace creation, cleanup, and pull secret setup, making it usable on any cluster with kubectl access.Tested: